-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Wrap text in tooltips, hints and calltips #9585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty good, thanks @dalthviz!
I left you some minor comments. The only thing that I don't like about your changes is that now there's no blank line between the signature and the docstring (as before). Please take a look at that.
@dalthviz, did you try this with the Java LPS server to see how things look there? |
@ccordoba12 I have been asking @andfoy about what server to launch and how to do it, although I have not test it yet with any server besides the Python one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty cool, thanks a lot @dalthviz!
I left you a couple of comments to make calltips in the IPython console language independent. After implementing them, please test how things look with Julia.
For that, please install Julia in a new env through conda-forge, then follow the IJulia instructions on how to install that kernel, and finally start a new kernel in the console and connect to it using our "Connect to an external kernel" dialog.
ed058c9
to
89e6362
Compare
89e6362
to
35768d0
Compare
@ccordoba12 a preview with |
Things look pretty good with Julia, thanks @dalthviz! One small detail though: in your last screenshots there's a blank line at the beginning of the calltip that shouldn't be there. Please see how to remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment, then this should be ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @dalthviz, I just noticed another shortcoming that we should fix before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz, great work here!
Description of Changes
Wrap text of the warnings and hover tips
Elements
Editor
Console
Hints
Width 120
Improve handling of signature and documentation in the IPython Console
Issue(s) Resolved
Fixes #9543
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz