Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Wrap text in tooltips, hints and calltips #9585

Merged
merged 14 commits into from
Jun 20, 2019

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Jun 15, 2019

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Wrap text of the warnings and hover tips

Elements

  • Calltips

Editor

editor

Console

console

  • Tooltips

k
kk

  • Hints
    Width 120
    hint

  • Improve handling of signature and documentation in the IPython Console

console_call

Issue(s) Resolved

Fixes #9543

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz changed the title Wrap text in tooltips, hints and calltips PR: Wrap text in tooltips, hints and calltips Jun 15, 2019
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good, thanks @dalthviz!

I left you some minor comments. The only thing that I don't like about your changes is that now there's no blank line between the signature and the docstring (as before). Please take a look at that.

spyder/widgets/mixins.py Outdated Show resolved Hide resolved
spyder/widgets/mixins.py Outdated Show resolved Hide resolved
spyder/widgets/mixins.py Outdated Show resolved Hide resolved
@ccordoba12
Copy link
Member

@dalthviz, did you try this with the Java LPS server to see how things look there?

@dalthviz
Copy link
Member Author

@ccordoba12 I have been asking @andfoy about what server to launch and how to do it, although I have not test it yet with any server besides the Python one

spyder/widgets/mixins.py Outdated Show resolved Hide resolved
spyder/widgets/mixins.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty cool, thanks a lot @dalthviz!

I left you a couple of comments to make calltips in the IPython console language independent. After implementing them, please test how things look with Julia.

For that, please install Julia in a new env through conda-forge, then follow the IJulia instructions on how to install that kernel, and finally start a new kernel in the console and connect to it using our "Connect to an external kernel" dialog.

spyder/plugins/ipythonconsole/widgets/help.py Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/help.py Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/help.py Outdated Show resolved Hide resolved
@dalthviz
Copy link
Member Author

dalthviz commented Jun 19, 2019

@ccordoba12 a preview with Julia:

imagen
imagen

@ccordoba12
Copy link
Member

ccordoba12 commented Jun 19, 2019

Things look pretty good with Julia, thanks @dalthviz!

One small detail though: in your last screenshots there's a blank line at the beginning of the calltip that shouldn't be there. Please see how to remove it.

@dalthviz
Copy link
Member Author

A new preview with Julia:
imagen

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment, then this should be ready.

spyder/plugins/ipythonconsole/widgets/help.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @dalthviz, I just noticed another shortcoming that we should fix before merging.

spyder/plugins/editor/widgets/codeeditor.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz, great work here!

@ccordoba12 ccordoba12 merged commit 40eca93 into spyder-ide:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap text in warnings and hover tips
3 participants