Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Directives #7

Closed
spyoungtech opened this issue Dec 12, 2018 · 3 comments
Closed

Missing Directives #7

spyoungtech opened this issue Dec 12, 2018 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@spyoungtech
Copy link
Owner

Currently the directives implementations are incomplete. Particularly, directives which take in parameters are not fully implemented.

I think defaults for arguments should be the same as in AutoHotkey, unless a good argument can be made for a more sensible default. We may also opt to provide defaults where AutoHotkey does not.

Anything that is deprecated, not recommended, or being removed in AutoHotkey v2.0 should not be implemented.

@spyoungtech spyoungtech changed the title Directives Missing Directives Dec 12, 2018
@spyoungtech
Copy link
Owner Author

I believe, if you know what arguments are expected, you can actually instantiate the incomplete directives.

So, specifically, the goal here is to add __init__ methods to incomplete directives and provide the proper signature and docstrings.

@spyoungtech spyoungtech added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 19, 2018
@Nickiel12
Copy link
Contributor

Could you define "directive" in this use case?

@spyoungtech
Copy link
Owner Author

Directives, as in AutoHotkey script directives. Some examples include #NoEnv #NoTrayIcon #Persistent and many more. The wrapper implements these in directives.py -- For instance, the implementation of ClipboardTimeout maps to the Autohotkey directive #ClipboardTimeout

Some directives are missing, others take arguments that could be defined and documented.

Hope that answers your question @Nickiel12

spyoungtech added a commit that referenced this issue Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants