- Revision files are now written out using the 'wb' modifier to

``open()``, since Mako reads the templates with ``'rb'``, thus preventing CRs from being doubled up as has been observed on windows. fixes #234
sqlalchemy · Oct 20, 2014 · d81619b · d81619b
1 parent ac95bad
commit d81619b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/alembic/util.py b/alembic/util.py
@@ -58,7 +58,7 @@ def _safe_int(value):
 
 
 def template_to_file(template_file, dest, **kw):
-    with open(dest, 'w') as f:
+    with open(dest, 'wb') as f:
         f.write(
             Template(filename=template_file).render(**kw)
         )

diff --git a/docs/build/changelog.rst b/docs/build/changelog.rst
@@ -5,6 +5,14 @@ Changelog
 .. changelog::
     :version: 0.7.0
 
+    .. change::
+      :tags: bug, templates
+      :tickets: 234
+
+      Revision files are now written out using the ``'wb'`` modifier to
+      ``open()``, since Mako reads the templates with ``'rb'``, thus preventing
+      CRs from being doubled up as has been observed on windows.
+
     .. change::
       :tags: bug, operations
       :tickets: 230