-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_foreign_key has wrong type annotations #1429
Comments
Hi, Indeed it seems to be a bug, since the normal create_fk has it optional: alembic/alembic/operations/ops.py Lines 595 to 696 in a22d21a
A PR would be appreciated! |
kasium
added a commit
to kasium/alembic
that referenced
this issue
Feb 22, 2024
The constraint name parameter of create_foreign_key should be optional, but the batch function defined it as str instead of Optional[str]. Closes sqlalchemy#1429
3 tasks
@CaselIT thanks for the confirmation. I'll open a PR |
CaselIT
pushed a commit
that referenced
this issue
Feb 22, 2024
The constraint name parameter of create_foreign_key should be optional, but the batch function defined it as str instead of Optional[str]. Closes #1429
Do you already have a plan when you want to release a new alembic version? |
Not yet, but it shouldn't be too long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
BatchOperations.create_foreign_key
states that theconstraint_name
should be a string, but it should beOptional[str]
Versions.
Additional context
I'm happy to open a PR, but first wanted to create an issue
Have a nice day!
The text was updated successfully, but these errors were encountered: