upgrade fails on oracle (version 0.7.x)

[sqlalchemy-bot]

Migrated issue, originally created by Ronny Pfannschmidt (@RonnyPfannschmidt)

i just tested the new version on oracle
and it seems the query responsible for updating the version table returns None on execution instead of a result with a rowcount

upon inspection of the source-code i noticed that the oracle implementation extends the _exec method without remembering/returning the return value generated by the super call to the default implementation

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

here's the stacktrace, please send these along as they help a lot

#!

Traceback (most recent call last):
  File "/Users/classic/dev/alembic/tests/test_version_table.py", line 159, in test_update_single_to_single
    self.updater.update_to_step(_up('a', 'b'))
  File "/Users/classic/dev/alembic/alembic/migration.py", line 494, in update_to_step
    self._update_version(from_, to_)
  File "/Users/classic/dev/alembic/alembic/migration.py", line 456, in _update_version
    if not self.context.as_sql and ret.rowcount != 1:
AttributeError: 'NoneType' object has no attribute 'rowcount'

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

-Repaired a regression in both the MSSQL and Oracle dialects whereby
the overridden _exec() method failed to return a value, as is
needed now in the 0.7 series. fixes #253

• add backend to UpdateRevTest which does a great job testing
  _exec() pathing for all backends

→ 206143c

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed