-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ensure_version command #965
Conversation
Looks great. Could you also add changelog entry? Similar to https://github.com/sqlalchemy/alembic/blob/main/docs/build/unreleased/test_changes.rst with also a line |
So a new file in the folder? |
Also the 3.10 tests are failing.
How can I fix this? |
yes. the name is the same as the issue number. so 964.rst |
guessing here, but I think you should add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision a85d2ac of this pull request into gerrit so we can run tests and reviews and stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision a85d2ac of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change a85d2ac: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3302 |
thanks. will import in in gerrit so we can review properly |
mike bayer (zzzeek) wrote: sorry for the delay here, we have a huge backlog of issues for sqlalchemy and others View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3302 |
mike bayer (zzzeek) wrote: thanks! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3302 |
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3302 has been merged. Congratulations! :) |
Closes #964
Description
Add a new command which creates the alembic_version table. Basically this was possible before by combining stamp and heads but was not nice to use. Using pure stamp is not possible.
Basically, the command does just call the
_ensure_version_table
method which existed before.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!