Avoid warnings under Python 3.10 #328
Conversation
|
this is great, let me try running this on CI which Im not even sure is working for Mako right now but will have to get this released. |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision c18d14d of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change c18d14d: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2470 |
|
you had a pep8 failure: can you force-push an adjustment ? thanks |
encukou
force-pushed
the
py310warnings
branch
from
c18d14d
to
c732cbf
Compare
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision c732cbf of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset c732cbf added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2470 |
| spec = util.spec_from_file_location(module_id, path) | ||
| module = util.module_from_spec(spec) | ||
| sys.modules[module_id] = module | ||
| spec.loader.exec_module(module) |
There was a problem hiding this comment.
do we want to have:
del sys.modules[module_id]
here? the idea is to not pollute sys.modules. seems to have all tests pass.
There was a problem hiding this comment.
Oh dear, I left sys.modules[module_id] = module in. I didn't mean to do that.
module_from_spec/exec_module doesn't put the module in sys.modules in the first place.
I removed the line and adjusted the test to check that sys.modules isn't polluted.
- In Python 3.5+, use spec_from_file_location(), module_from_spec() and exec_module() rather than the deprecated load_module(). This avoids recording the imported module in sys.modules. - Delete sys.modules[module_id] directly in load_module(), since that's what all call sites did. - Adjust tests.
encukou
force-pushed
the
py310warnings
branch
from
c732cbf
to
87c1d09
Compare
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 87c1d09 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 87c1d09 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2470 |
|
mike bayer (zzzeek) wrote: Code-Review+2 Workflow+2 thanks so much for taking care of this!! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2470 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2470 has been merged. Congratulations! :) |
|
mako 1.1.4 is released thanks very much ! |
|
Thank you for Mako! :) |
This modernizes the code to avoid
DeprecationWarningandResourceWarningencountered in the test suite under Python 3.10a4:This changes the semantics of the
compat.load_modulefunction: on Python 3.5+, the module is no longer inserted insys.modules. All non-test calls diddel sys.modules[self.module_id]right after the call, anyway. On older Python, the module is inserted and then deleted.(Some additional
DeprecationWarningcome from Setuptools: pypa/setuptools#2517)