Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility properties to new PG Range class #8927

Closed
wants to merge 1 commit into from

Conversation

lelit
Copy link
Collaborator

@lelit lelit commented Dec 4, 2022

This adds a bunch of properties to new PG Range class for compatibility with other implementations, providing a more similar API to access emptiness and bounds status.

Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 8b9e7b7 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change 8b9e7b7: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4266

@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

I reworded some of the docstrings and also implemented a quick pep-484 typing on top (lots of type: ignores though).

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4266

@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

the rebase didnt work? not sure what that was about

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4266

@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

recheck

weird things going on

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4266

@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

OHHH it's my fault, there's crap in the directory

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4266

@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

recheck

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4266

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4266 has been merged. Congratulations! :)

@lelit lelit deleted the smoother-pg-range branch December 5, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants