Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix versioned-history example #9221

Closed
wants to merge 1 commit into from

Conversation

martell
Copy link

@martell martell commented Feb 2, 2023

Code to show issue as described in #9220

run python3 -m unittest examples/versioned_history/test_versioning.py

@zzzeek I hope you can help, this is broken since 5ec5b0a

@zzzeek
Copy link
Member

zzzeek commented Feb 2, 2023

seems fine, we can merge

Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 38eac57 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change 38eac57: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4415

@zzzeek
Copy link
Member

zzzeek commented Feb 2, 2023

is there a reason this is in draft still?

@zzzeek
Copy link
Member

zzzeek commented Feb 2, 2023

closing this, the change to make the test work as written I'll share on the issue, however, that's not how I want to do it

@zzzeek zzzeek closed this Feb 2, 2023
@sqla-tester
Copy link
Collaborator

mike bayer (zzzeek) wrote:

i did a full rework of the example in https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4422

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4415

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4415 has been abandoned. That means that at least for the moment I need to close this pull request. Sorry it didn't work out :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants