pg-gen: implement information_schema shema #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabbes
commented
Aug 23, 2022
| "out": "go_pgx" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
@kyleconroy I found that undoing the nesting (and using multiple sql array elements, made these things a lot easier to test.
| SELECT * from pg_catalog.pg_timezone_names; | ||
|
|
||
| -- name: GetTables :many | ||
| SELECT table_name::text from information_schema.tables; |
There was a problem hiding this comment.
I had to cast these to ::text since I think the information_schema uses a database type that is not currently recognized by sqlc (it used interface{}). It might be a simple fix to change that.
kyleconroy
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1800
Was relatively straightforward after #1811
I recommend reviewing commit by commit - since I separated out the "auto-generated files commits" from the rest of the changes.