Only enable postgresql support when cgo is enabled as it is required #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Feb 14, 2023
| @@ -1,5 +1,5 @@ | |||
| //go:build windows | |||
| // +build windows | |||
| //go:build windows || !cgo | |||
There was a problem hiding this comment.
Had to rename this file since _windows was implicitly causing the file to only be used on windows, independent of the build tag
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2050
postgresql parser requires cgo to build the native parser library, which can cause build issues such as #1956. Currently there is no way to disable support when it is not needed and the build issues can cause a problem. With this change,
CGO_ENABLED=0can be used to work with the other parsers and avoid build issues.