feat(sqlite) adding support for nullable types #2157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kyleconroy friendly bump :) any thoughts on this? |
|
Hey @kyleconroy friendly bump :). There are some merge conflicts I need to fix, but I want to make sure you agree with the direction of adding |
|
I would love something like this, also for the functions |
|
Closed via #2157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like sqlite does not support the syntax sqlc.narg() because it doesn't have a concept of schemas like postgres, so the engine parser fails. There are open issues (#1962 #1881) demonstrating this.
In this PR I'm proposing a slightly different syntax for nullable paramters to satisfy the sqlite language syntax:
sqlc_narg. @kyleconroy let me know what you think, and I can add tests and update docs if you agree.