feat(sqlite) add support sqlc functions #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakobera
force-pushed
the
feat-sqlite-sqlc-functions
branch
from
fdd53b6
to
05a9379
Compare
hakobera
force-pushed
the
feat-sqlite-sqlc-functions
branch
from
05a9379
to
44c3ec7
Compare
orisano
reviewed
May 16, 2023
internal/engine/sqlite/convert.go
Outdated
| @@ -325,6 +354,10 @@ func (c *cc) convertMultiSelect_stmtContext(n *parser.Select_stmtContext) ast.No | |||
| } | |||
| } | |||
|
|
|||
| func (c *cc) convertExprListContext(n *parser.Expr_listContext) ast.Node { | |||
| return c.convertExprLists(n.AllExpr()) | |||
There was a problem hiding this comment.
I think you are returning a nested "ast.List" here, but an un-nested "ast.List" would be correct.
Suggested change
| return c.convertExprLists(n.AllExpr()) | |
| return c.convertExprLists(n.AllExpr()).Items[0] |
There was a problem hiding this comment.
@orisano Thank you for pointing out. I checked SQLite SQL syntax and confirmed parser.Expr_listContext should return ast.List. I thought I can reuse c.convertExprLists() but it's specialized for values for selectStatement.
There was a problem hiding this comment.
Updated in 2adb18f
kyleconroy
approved these changes
Jun 6, 2023
|
10/10, no notes |
This was referenced Jun 6, 2023
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add support sqlc functions below to SQLite.
sqlc.arg()&@<variable>notationsqlc.narg()sqlc.embed()sqlc.slice()I know we already have similar PR #2157 by @aloisbarreras and #2259 by @orisano .
Both are introducing new syntax like
sqlc_arg()as alternative ofsqlc.arg()because of current SQLite parser's limitation.It works but I prefer to use same syntax for all supported engines to keep consistency, so I modified SQLite parser to accept
sqlc.schema notation.Fixes #1881 #1962.