Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-DbaWhoIsActive - Use Save-DbaCommunitySoftware to download latest version? #7884

Closed
andreasjordan opened this issue Oct 22, 2021 · 4 comments · Fixed by #7901
Closed
Labels

Comments

@andreasjordan
Copy link
Contributor

Summarize Functionality

Do we want to use Save-DbaCommunitySoftware to download the lastest version of sp_WhoIsActive?

At the moment, we use Save-DbaCommunitySoftware for:

Currently, Install-DbaWhoIsActive searches for the last release and downloads that. With Save-DbaCommunitySoftware we would just get the current master branch (as there is no dev branch).

Is there a command that is similiar or close to what you are looking for?

No

Technical Details

No response

@andreasjordan andreasjordan added feature triage required New issue that has not been reviewed by maintainers labels Oct 22, 2021
@MikeyBronowskiQ
Copy link

I did not know that command! Nice! I think it's a good idea to include the sp_WhoIsActive.

@andreasjordan
Copy link
Contributor Author

As I just coded a release download as well (for SQLWATCH - #7891) we could also use the latest release with sp_WhoIsActive as well.
So is a release download better that a branch download? I would still vote for branch download.

@andreasjordan andreasjordan removed the triage required New issue that has not been reviewed by maintainers label Oct 26, 2021
@wsmelton
Copy link
Member

wsmelton commented Oct 27, 2021

From GitHub perspective the proper method is to download the release. Not all maintainers do this though so we are forced to use the branch download which has to also download the git database of that branch (the release zip doesn't have all the extra data in it).

@andreasjordan
Copy link
Contributor Author

Thanks for the feedback. Then I will go for the release download. Will do that after the open pr in merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants