Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Update to better support Smo Server Reuse and Azure #5204

Merged
merged 13 commits into from Mar 15, 2019

Conversation

Projects
None yet
1 participant
@potatoqualitee
Copy link
Member

potatoqualitee commented Mar 14, 2019

Certain Properties in the SMO recycler section of [dbainstanceparameter] caused the connection to initiate and reset. So I modified this to the bare minimum.

I can't figure out how to keep the Port, so we'll see where that takes us. So far, the tests are passing.

Initially, I added a NetPort in Connect-DbaInstance but removed it because I couldn't get it to work.

potatoqualitee added some commits Mar 14, 2019

Revert "try without port"
This reverts commit 8c5bca3.
Revert "undo"
This reverts commit 62d4592.
Revert "clean pdb"
This reverts commit f99d84f.

potatoqualitee added some commits Mar 14, 2019

fixed issue with sending no computername
this may introduce perf issues when doing hundreds of servers
@potatoqualitee

This comment has been minimized.

Copy link
Member Author

potatoqualitee commented Mar 15, 2019

test failure due to unrelated, one pass, also got fred's approval

@potatoqualitee potatoqualitee merged commit d21cdc2 into development Mar 15, 2019

1 of 2 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@potatoqualitee potatoqualitee deleted the library branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.