Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-DbaDbRoleMember - Changed output to align with ServerRoleMember #7350

Merged
merged 5 commits into from
May 24, 2021
Merged

Get-DbaDbRoleMember - Changed output to align with ServerRoleMember #7350

merged 5 commits into from
May 24, 2021

Conversation

andreasjordan
Copy link
Contributor

@andreasjordan andreasjordan commented May 21, 2021 •
edited

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes )
  • Breaking change (effects multiple commands or functionality, fixes Get-DbaDbRoleMember user status Enabled/Disabled #4964 )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Changed output to align with Get-DbaServerRoleMember

image

jpomfret
jpomfret approved these changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@jpomfret jpomfret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@jpomfret
Copy link
Collaborator

tests for Get-DbaPermission failed but runs ok locally - seems to be unrelated. Looks like all ran successfully last time as well

@jpomfret jpomfret merged commit f25343a into development May 24, 2021
@wsmelton wsmelton deleted the 4964_GetDbaDbRoleMember_Output branch May 25, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpomfret jpomfret jpomfret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-DbaDbRoleMember user status Enabled/Disabled
3 participants
@andreasjordan @jpomfret @potatoqualitee