Get-DbaHelp, gfm compatibility #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the read-dbaauditfile test is failing a lot. not only on this PR ^_^ |
|
Yeah, I removed it from test rotation for now @niphlod. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Purpose
Compared to what is used on the docs.dbatools.io site, which uses markdown with the "gfm" dialect, some fixes were needed as moving forward PS7's ConvertFrom-Markdown will be used (see dataplat/docs#36) . The point is/was that in gfm-style soft breaks (i.e. a line ending in our inline help) ended up being properly separated by a
<br>.ConvertFrom-Markdown from PS7 doesn't support it, so we need to generate it in here.