Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-DbaAgentJob - Added parameter test #7367

Merged
merged 4 commits into from
May 27, 2021

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes [Bug] Set-DbaAgentJob - error setting OperatorEmail w/o EmailLevel #6847 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

For all three possible types (e-mail, net send, page) now both operator and level have to be set, otherwise a warning is thrown and the command returns.

Also corrected some comments.

image

@potatoqualitee
Copy link
Member

Unsure what's going on, but the changes seem to impact other AgentJob commands which causes failures :/

@andreasjordan
Copy link
Contributor Author

Ok, I'll have a closer look.

@andreasjordan
Copy link
Contributor Author

Ok, fixed it. Failed test seem unrelated.

@niphlod
Copy link
Contributor

niphlod commented May 26, 2021

rekicked. BTW, for all, if you don't wanna wait for the whole suite of tests to run, include a (do whatever) in the commit message.
appveyor will target any tests matching *whatever* and all the upper-level dependencies (meaning, all tests related to functions USING whatever). In this case, (do Set-DbaAgentJob) would be a good choice, but if you want to save keyboard presses, even (do Agent) works.

@potatoqualitee
Copy link
Member

parrrty!

@potatoqualitee potatoqualitee merged commit 63f5ea6 into development May 27, 2021
@potatoqualitee potatoqualitee deleted the 6847_SetDbaAgentJob_TestLevel branch May 27, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Set-DbaAgentJob - error setting OperatorEmail w/o EmailLevel
3 participants