-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-DbaDiskAlignment - corrected indentation #7369
Conversation
I can't get this to format properly, @niphlod any suggestions? I even cut/pasted from VSCode, used Invoke-DbatoolsFormatter and I deleted the command and readded it. Wtheck. |
don't get crazy over it, sometimes PSScriptAnalyzer is just ....... magic. And I start feeling that VSCode uses PSScriptAnalyzer with an interface Powershell hasn't. |
I thinks it's the |
Changed the description so we can close #6406. As long as I don't have to work on the command, I don't care about the indentation. |
Thank you, @niphlod! Does that mean I can close this, @andreasjordan ? |
I changed the description. Can you merge this change? |
confermed, PSScriptAnalyzer hiccups on the foreach, attached you can find what it thinks should be the correct format. now that I'm so involved, I'll try to rewrite the parts that are that trap PSScriptAnalyzer in a hiccup and see what's what. Give me a few hours |
Great. Thanks. |
Thanks to you both! How the heck did you get that to work, @niphlod ? |
@potatoqualitee : just rewrote the ugly foreach-object with a zillion pipes to a plain foreach() with a returning pscustomobject. |
Just corrected the indentation to better be able to work on #6406. No other change to the code.
Update: Fixes #6406.