Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-DbaAgBackupHistory - Use Where-Object instead of .Where() for PS3 #7382

Merged
merged 4 commits into from
May 29, 2021
Merged

Get-DbaAgBackupHistory - Use Where-Object instead of .Where() for PS3 #7382

merged 4 commits into from
May 29, 2021

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes [Bug] Get-DbaAgBackupHistory uses .Where () #7381 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

For PS3 support.

@andreasjordan
Copy link
Contributor Author

Just found an issue while testing: If -Database is not set, info about all databases is returned. As Documentation says "Specifies one or more database(s) to process. If unspecified, all databases of the availability group will be processed." I added this filter when getting the results from Get-DbaDbBackupHistory.

jpomfret
jpomfret approved these changes May 29, 2021
View reviewed changes
Copy link
Collaborator

@jpomfret jpomfret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - thank you :)

@jpomfret jpomfret merged commit f0ec617 into development May 29, 2021
@andreasjordan andreasjordan deleted the 7381_GetDbaAgBackupHistory_Where branch July 4, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpomfret jpomfret jpomfret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Get-DbaAgBackupHistory uses .Where ()
2 participants
@andreasjordan @jpomfret