[#7383] Added parameter CommandTimeOut to the function Copy-DbaDbTableData #7384
Conversation
|
You will have to add the parameter to the test as well. |
Changing documentation
|
thanks @andreasjordan , I fixed it |
bin/dbatools-index.json
Outdated
| @@ -4773,6 +4773,15 @@ | |||
| "5000", | |||
| "" | |||
| ], | |||
| [ | |||
There was a problem hiding this comment.
Welcome and thanks for the contribution!! Can you remove this file from the PR please - this one gets auto generated by the module.
There was a problem hiding this comment.
Yes, indeed thank you. Also, cool avatar!
There was a problem hiding this comment.
Thank you guys and sorry for the delay. Working on it now
| $knownParameters += [System.Management.Automation.PSCmdlet]::CommonParameters | ||
|
|
||
| (@(Compare-Object -ReferenceObject ($knownParameters | Where-Object {$_}) -DifferenceObject $params).Count ) | Should -Be 0 |
There was a problem hiding this comment.
Also could you remove the whitespace please - there is a Invoke-DbatoolsFormatter that might help - or some .vscode settings in the code also (if you're using vscode)
There was a problem hiding this comment.
This whitespaces were removed by vscode when I saved the file. Do you want me to revert them?
functions/Copy-DbaDbTableData.ps1
Outdated
| @@ -94,6 +94,9 @@ function Copy-DbaDbTableData { | |||
| .PARAMETER BulkCopyTimeOut | |||
| Value in seconds for the BulkCopy operations timeout. The default is 5000 seconds. | |||
|
|
|||
| .PARAMETER CommandTimeOut | |||
| Value in seconds for the reader command operations timeout. The default is 0 seconds (no timeout). | |||
There was a problem hiding this comment.
This has an effect on more than the reader command since we pass the connection string with the command timeout set to the BulkCopy object. Bulk copy operation will still adhere to the command timeout, if the network packets hit the command timeout then that bulk copy will fail as well.
| Value in seconds for the reader command operations timeout. The default is 0 seconds (no timeout). | |
| Gets or sets the wait time (in seconds) before terminating the attempt to execute the reader and bulk copy operation. The default is 0 seconds (no timeout). |
There was a problem hiding this comment.
Thanks for the suggestion, I liked it. Will change now
Improving description of commandtimeout parameter
|
Can we change "TimeOut" to "Timeout"? |
Nice suggestion. I actually saw that before creating it, but I just kept that standard from the BulkCopyTimeOut. I should have changed it but didn't want to be as forward as this. Will change now |
|
One last change: "$bulkCopy.BulkCopyTimeOut" to "$bulkCopy.BulkCopyTimeout" please. |
Done! 😄 |
|
Thanks! How new releases works? When can I expect to have a new version with this new functionality? Sorry to ask this, just to have an idea really. |
|
@mrlmachado - it's in the gallery now 🥳 We're likely going to be releasing every other day or so unless there's a batch of PRs then I'll just do it daily |
Type of Change
Purpose
Sometimes the reader command runs indefinitely and needs to have a timeout. This change adds this as a parameter to the function
Approach
Adding a parameter to a function