Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-DbaDbSnapshot fix for Linux paths #7386

Merged
merged 1 commit into from
May 29, 2021
Merged

New-DbaDbSnapshot fix for Linux paths #7386

merged 1 commit into from
May 29, 2021

Conversation

jpomfret
Copy link
Collaborator

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Fix for creating snapshots on linux - building the path and the slashes are for windows
image

Approach

Test if it's a linux system and then swap slashes. (I found this in another command - if there is a better test for this I'm happy to switch it).

Commands to test

Run this against a docker container or something linuxy

New-DbaDbSnapshot -SqlInstance mssql1 -Database AdventureWorks  -Name testSnap2

Screenshots

image

@jpomfret jpomfret closed this May 28, 2021
@jpomfret jpomfret reopened this May 28, 2021
Copy link
Contributor

@andreasjordan andreasjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@potatoqualitee
Copy link
Member

Thank you both! 🥳

@potatoqualitee potatoqualitee merged commit 894214e into dataplat:development May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants