Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove-DbaDbSnapshot - should ask for confirmation #7388

Merged
merged 2 commits into from
May 31, 2021
Merged

Remove-DbaDbSnapshot - should ask for confirmation #7388

merged 2 commits into from
May 31, 2021

Conversation

jpomfret
Copy link
Collaborator

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Removing snapshots should ask for confirmation

Approach

Change confirmimpact to high

Commands to test

New-DbaDbSnapshot -SqlInstance mssql1 -Database AdventureWorks 
Get-DbaDbSnapshot -SqlInstance mssql1 -Database AdventureWorks | Remove-DbaDbSnapshot 

Should get a prompt to drop the snap

Screenshots

image

Copy link
Contributor

@andreasjordan andreasjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@potatoqualitee
Copy link
Member

same! This is a breaking change, but it's a good one (and I don't think a ton of ppl are using snapshots yet?) I'm still testing the dev branch so ill merge but release later this week 💯

@potatoqualitee potatoqualitee merged commit da3f1f5 into dataplat:development May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants