New command for removing a linked server

[lancasteradam]

Type of Change

• Bug fix (non-breaking change, fixes # )
• New feature (non-breaking change, adds functionality, fixes Commands for managing Linked Server #6506 )
• Breaking change (effects multiple commands or functionality, fixes # )
• Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
• Nunit test is included
• Documentation
• Build system

Purpose

Basic command for removing a linked server.

Commands to test

See the integration tests and the examples.

[andreasjordan]

Have you tried to use Get-DbaLinkedServer and Remove-DbaLinkedServer in one pipeline? I had issues with that in other Remove- commands and had to move the drop to the end block.
So change the second last test to:

Get-DbaLinkedServer -SqlInstance $instance2 -LinkedServer "LS2_$random" | Remove-DbaLinkedServer -WarningVariable warn

and then test $warn for beeing null or empty.

[lancasteradam]

Thank you @andreasjordan. I have incorporated your feedback.

[potatoqualitee]

Thank you 🙇🏼 ! These are great. Will add to manifest and release today.

[garyhampson]

Hi @lancasteradam - When running this:
Get-DbaLinkedServer -SqlInstance MYSERVER -LinkedServer LINKEDSERVERNAME | Remove-DbaLinkedServer -Confirm:$false
I get the following error:
WARNING: [17:00:32][Remove-DbaLinkedServer] Failure on MYSERVER to remove the linked server LINKEDSERVERNAME | There are still remote logins or linked logins for the server 'LINKEDSERVERNAME'.

This is running 1.0.165 on PS 6.2.4 Core

[lancasteradam]

Hi @garyhampson,

Yes, the scope for this first round of linked server commands was more on the simple side of things. Feel free to create an enhancement request to add in the option to remove the logins. In the meantime, you could use https://docs.dbatools.io/Get-DbaLinkedServer to obtain the linked server and then iterate through the logins on that object and call drop() before dropping the linked server itself.

Regards,
Adam