Completely rewritten Add-DbaAgDatabase / Added Test-DbaAvailabilityGroup #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmelton
reviewed
Jun 6, 2021
wsmelton
reviewed
Jun 6, 2021
Co-authored-by: Shawn Melton <11204251+wsmelton@users.noreply.github.com>
|
how're we looking @wsmelton ? Thank you both for your work on this 🌈 |
|
LGTM Note I don't have environment anymore to do integration testing for AGs but logically it looks right. |
|
I have not tested but code looks reasonable to Shawn, and I see a passed integration test on appveyor. I'll add new command to manifest and release today, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Purpose
Adding more functionality.