Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Watch commands cannot be used in PowerShell 7 #7414

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Conversation

wsmelton
Copy link
Member

@wsmelton wsmelton commented Jun 5, 2021

Tempoary fix until we address import process.

Type of Change

  • Bug fix (non-breaking change, fixes Install-DbaSqlWatch broken in PowerShell 7  #6567 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

The DLL used is not supported in dotnet Core, only .NET 4.6 making this command only compatible with Windows PowerShell.

SQL Watch commands in addition to any command trying to use the Microsoft.SqlServer.Dac.dll are now going to throw a message that PowerShell Core is not supported if they are on Windows.

The commands are only imported at this time if they are Windows but we do not address the Edition of PowerShell in our import process. Our import process needs to have an additional check on PowerShell Edition so we can properly exclude these commands on import and lessen the confusion.

Tempoary fix until we address import process.
Cannot be used in PowerShell 7+
@wsmelton
Copy link
Member Author

wsmelton commented Jun 6, 2021

Odd failure of Get-DbaDbSharePoint, not related to PR.

@wsmelton wsmelton merged commit 3b1da78 into development Jun 6, 2021
@wsmelton wsmelton deleted the fix-sqlwatch branch June 6, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install-DbaSqlWatch broken in PowerShell 7
1 participant