Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove-DbaAgentSchedule - Complete rewrite #7430

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Remove-DbaAgentSchedule - Complete rewrite #7430

merged 6 commits into from
Jun 18, 2021

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes [Bug]Remove-DbaAgentSchedule deletes wrong schedule #6890 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Now using same pattern as Remove-DbaDbSequence, but we have to wait on a decision about the output properties to finish this, see #7408.

@andreasjordan andreasjordan mentioned this pull request Jun 10, 2021
Closed
4 tasks
@potatoqualitee
Copy link
Member

@sanderstad - can you take a look and approve? 🙇🏼

@andreasjordan andreasjordan marked this pull request as ready for review June 15, 2021 11:55
@wsmelton wsmelton requested review from sanderstad and removed request for wsmelton June 15, 2021 12:18
sanderstad
sanderstad approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@sanderstad sanderstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, the methods and properties you used make it more sophisticated

@potatoqualitee potatoqualitee merged commit 2825505 into development Jun 18, 2021
@potatoqualitee potatoqualitee deleted the 6890_RemoveDbaAgentSchedule_rewrite branch June 18, 2021 15:33
@potatoqualitee
Copy link
Member

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderstad sanderstad sanderstad approved these changes

@potatoqualitee potatoqualitee Awaiting requested review from potatoqualitee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]Remove-DbaAgentSchedule deletes wrong schedule
3 participants
@andreasjordan @potatoqualitee @sanderstad