Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor runner, test dependants #7435

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Jun 14, 2021

appveyor runner now tests also all dependants when asked to run specific tests

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

To cut off PR times, one should include the magic "(do whatever)" anywhere in the commit message. This change allows to test (like before) everything that matches "whatever" but also, on top, all functions that have a dependency on what's originally targeted. Also, dbatools.tests.ps1 always runs so it checks for issues, formatting, help parameters and so on.

@potatoqualitee
Copy link
Member

gorgeous! is it ready to merge? btw, for anyone reading this, I'm a bit slower with the releases because we're making changes to connect-dbainstance and i'm being extra cautious.

@niphlod
Copy link
Contributor Author

niphlod commented Jun 15, 2021

yep, it only changes behaviour for "(do something)" commit messages.
Next steps are:

  • re-runs of failed tests (without resorting to calling the appveyor api), I was thinking about trying 3x for each failed tests
  • separate runners for pester4 tests and for pester5 (given that pester support is in, as reported by @wsmelton )

@potatoqualitee
Copy link
Member

Awesome, thank you niph! 🙇🏼

@potatoqualitee potatoqualitee merged commit c673d54 into dataplat:development Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants