Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve-NetBiosName - Return ComputerNamePhysicalNetBIOS if clustered #7436

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes [Bug] export-dbalinkedserver not working in a sql clustered instance #6053 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (will change functionality of all commands using Resolve-NetBiosName against clustered instances)
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Resolve-NetBiosName now does what the name says: It resolves the (physical) NetBiosName of the computer, so in clustered instances the ComputerName of the cluster node the instance currently runs on.

So no change for all non-clustered instances. Only risk: This would fail if the computer would only accept connections to the cluster name and not the node name. But I think the more offen case is like in the linked issue, that the computer only accepts connection to the node name.

@andreasjordan
Copy link
Contributor Author

This pull request can be closed if we work on #5988 and remove Resolve-NetBiosName and replace it by Resolve-DbaNetworkName in all commands, as the later returns information about the physical node instead of the virtual cluster name.

@potatoqualitee
Copy link
Member

I dig it, thank you!

@potatoqualitee potatoqualitee merged commit 06a813c into development Jun 18, 2021
@potatoqualitee potatoqualitee deleted the 6053_ResolveNetBiosName_Cluster branch June 18, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] export-dbalinkedserver not working in a sql clustered instance
2 participants