Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start-DbaAgentJob, fixes #7444 #7445

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Jun 17, 2021

Type of Change

  • Bug fix (non-breaking change, fixes [Bug] Start-DbaAgentJob verbose output "Cannot convert value" error for job step #7444 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Fix issues in parsing CurrentStep. Weird that we got that far, because SMO doesn't expose a nice interface for it. The point is that the reported property is a string that is "number (stepname)".
I just fixed the logic for parsing

@potatoqualitee
Copy link
Member

This has that dang formatting failure :/

@potatoqualitee
Copy link
Member

AWW YEAH! It worked! Thanks 🐬 !

@potatoqualitee potatoqualitee merged commit 177f45d into dataplat:development Jun 18, 2021
@niphlod
Copy link
Contributor Author

niphlod commented Jun 18, 2021

whoopsie, sorry, I rushed it while doing 31298312 other things.

@potatoqualitee
Copy link
Member

thank you for adding this to your list <3

@wsuhoey
Copy link
Collaborator

wsuhoey commented Jun 18, 2021

Confirmed fixed in 1.0.158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Start-DbaAgentJob verbose output "Cannot convert value" error for job step
3 participants