Connect-DbaInstance - Make AccessToken more convenient
#7868
Conversation
| @@ -876,6 +877,16 @@ function Connect-DbaInstance { | |||
|
|
|||
| # If we have an AccessToken, we will build a SqlConnection | |||
| if ($AccessToken) { | |||
| # Check if token was created by New-DbaAzAccessToken or Get-AzAccessToken | |||
| Write-Message -Level Debug -Message "AccessToken detected, checking for string or PsObjectIRenewableToken" | |||
| if ($AccessToken | Get-Member | Where-Object Name -eq GetAccessToken) { | |||
There was a problem hiding this comment.
You can utilize checking the exact type using -is [TypeName] in PowerShell; may run a bit more efficient. (It is one that has been in .NET for long time show should work back to PS 3.0 as well.)
if ($AccessToken -is [PSObjectIRenewableToken]) {
There was a problem hiding this comment.
that's quite a bit faster! I'll update, thank you 🙇🏼
There was a problem hiding this comment.
Unfortunately, that class is not available until the command is run. So if I do a test, and it's any other type of object, there will be an error
There was a problem hiding this comment.
Correct, in the context of the function they have to pass the object so it will exists.
There was a problem hiding this comment.
More formal method would be to set the type of the parameter you are expecting. If you want them to pass in the object from the output of the other commands, just set the parameter as the type. (cuts out having to check for it)
Now, Connect-DbaInstance will automatically figure out the AccessToken, even if another type of object is returned.