New-DbaAvailabilityGroup - add a test before attempting to add database

[potatoqualitee]

Sometimes this awesome command would be too darn fast and the ag wasn't ready to accept a database. This waits until the state is connected before attempting to add.

[andreasjordan]

Good idea. But we should not only wait if we want to add databases within the command, but also wait in any case for the state "connected" before running the final Get-DbaAvailabilityGroup. Because then all other commands in a script that runs New-DbaAvailabilityGroup can rely on a ready-to-go AG. So maybe move the new block up to line 642?

[potatoqualitee]

good idea! moved it

[andreasjordan]

Maybe add a warning message, if $ready is still $false? I would not fail, but let the user know that the AG is maybe not yet ready. Then, if adding the databases failes, the user has a hint why adding databases failed.

[andreasjordan]

"One last thing": -not $ready is sufficent, -or $wait -gt 40 not needed.

[potatoqualitee]

I know, im just covering alll the bases 😅

[potatoqualitee]

sweet, thanks 👍🏼