fix the open/save query functionality #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
MasterOdin
added a commit
that referenced
this pull request
Nov 10, 2020
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #540
This broke in the move to electron 8.2.5 where electron 6 changed the signature of this function to have a callback to instead use a promise interface. This modifies the show(Save|Open)Dialog functions to now utilize that promise, while still wrapping the result into the same form as was being used before where the
resolveis given the singular filename (if there is one) while it rejects in cases where no file is selected (due to canceling) or we hit an error case.