Rename test/fixtures/parser directory to test/fixtures/dialects #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far. I see some CI checks are failing. Please ping me again when things are passing. |
Not my fault! 😁 Will wait for @alanmcruickshank to sort that out in the other PR and then update this before merging. |
alanmcruickshank
approved these changes
Oct 11, 2021
Codecov Report
@@ Coverage Diff @@
## main #1585 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9175 9175
=========================================
Hits 9175 9175 Continue to review full report at Codecov.
|
tunetheweb
changed the title
ttomasz
pushed a commit
to ttomasz/sqlfluff
that referenced
this pull request
Oct 12, 2021
…luff#1585) * Rename test/fixtures/parser to dialects * Rename * Revert keyword change Co-authored-by: Alan Cruickshank <alanmcruickshank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Makes progress on #1575 by renaming
test/fixtures/parsertotest/fixtures/dialectsto more accurately reflect what these tests are and to align to the source code these are testing.Are there any other side effects of this change that we should be aware of?
Could be some merge conflicts if anyone is working on changing these files but looks quiet at the mo so good time to do it!
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/parser(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.