Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake auto increments fixes #1620

Merged
merged 7 commits into from Oct 13, 2021

Conversation

myschkyna
Copy link
Contributor

Brief summary of the change made

Fixes #1619. The NumericLiteralValue was referred to by Grammar. This was however non existent. Replacing this with the NumericLiteralSegment fixed the issue.

Are there any other side effects of this change that we should be aware of?

Not that I'm aware of.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - think that was me!

@myschkyna
Copy link
Contributor Author

myschkyna commented Oct 13, 2021

@tunetheweb, I see that the Windows tests are failing. Is this something I can fix, or is it still related to GitHub Actions?

@tunetheweb
Copy link
Member

It's the GitHub Actions issue: https://www.githubstatus.com/

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1620 (5fa03a2) into main (0ebc703) will not change coverage.
The diff coverage is n/a.

❗ Current head 5fa03a2 differs from pull request most recent head 55a9dfe. Consider uploading reports for the commit 55a9dfe to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1620   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       131           
  Lines         9207      9208    +1     
=========================================
+ Hits          9207      9208    +1     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_tsql.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebc703...55a9dfe. Read the comment docs.

@tunetheweb
Copy link
Member

@myschkyna can you update the branch so we can merge this?

@myschkyna
Copy link
Contributor Author

Done @tunetheweb!

@tunetheweb
Copy link
Member

Cool will merge when tests complete.

BTW if you tick this box when opening PRs we can update this for you:

image

@myschkyna
Copy link
Contributor Author

Cool, didn't know that! Thanks!

@tunetheweb tunetheweb merged commit 14e1a23 into sqlfluff:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snowflake autoincrement: autoincrement raises RuntimeError
2 participants