New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake auto increments fixes #1620
Snowflake auto increments fixes #1620
Conversation
Merge updates on main from sqlfluff repo
Update main with sqlfluff main
Update main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops - think that was me!
@tunetheweb, I see that the Windows tests are failing. Is this something I can fix, or is it still related to GitHub Actions? |
It's the GitHub Actions issue: https://www.githubstatus.com/ |
Codecov Report
@@ Coverage Diff @@
## main #1620 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9207 9208 +1
=========================================
+ Hits 9207 9208 +1
Continue to review full report at Codecov.
|
@myschkyna can you update the branch so we can merge this? |
Update main
…uto-increments-fixes
Done @tunetheweb! |
Cool, didn't know that! Thanks! |
Brief summary of the change made
Fixes #1619. The NumericLiteralValue was referred to by Grammar. This was however non existent. Replacing this with the NumericLiteralSegment fixed the issue.
Are there any other side effects of this change that we should be aware of?
Not that I'm aware of.
Pull Request checklist