-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to simple API #1951
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 148 148
Lines 10300 10291 -9
=========================================
- Hits 10300 10291 -9
Continue to review full report at Codecov.
|
@barrywhart made the changes mentioned above, I think the switch to |
ahh coverage suggest I can happily remove the string input from Linter as well now, so will get that done |
This PR looks good to me. @alanmcruickshank: Any concerns about the changes to simplify the API? It introduces some breaking changes, but they make it a bit cleaner and easier to understand or document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with these changes. We should make a note that it introduces a breaking change in the changelog though. I think this probably should trigger a minor release too.
Brief summary of the change made
This PR aims to add basic type hinting to the simple API. Additionally I have added a
py.typed
file and included it insetup.cfg
so that the simple API is mypy compatible in external projects.Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withpython test/generate_parse_fixture_yml.py
or by runningtox
locally).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.