Grammar: Adds support for ALTER VIEW statement for Postgres dialect #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2096 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 148 148
Lines 10603 10608 +5
=========================================
+ Hits 10603 10608 +5
Continue to review full report at Codecov.
|
jpy-git
reviewed
Dec 12, 2021
Comment on lines
+1672
to
+1681
| Sequence( | ||
| "SET", | ||
| "DEFAULT", | ||
| OneOf( | ||
| Ref("LiteralGrammar"), | ||
| Ref("FunctionSegment"), | ||
| Ref("BareFunctionSegment"), | ||
| Ref("ExpressionSegment"), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
You're correct here. I noticed that the existing AlterTableActionSegment only allows expression segments when it should also account for the segments you have here. If you're interested would you be able to create a separate PR to match that line to the SET DEFAULT grammar you have here and add the corresponding unit tests? 😄
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Adds support for parsing
ALTER VIEWstatements for the Postgres dialectCloses #2094
Are there any other side effects of this change that we should be aware of?
None
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.