Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for more value types in ALTER TABLE ALTER COLUMN SET DEFAULT statement #2101

Merged
merged 1 commit into from Dec 12, 2021

Conversation

derickl
Copy link
Contributor

@derickl derickl commented Dec 12, 2021

Brief summary of the change made

Follow up from #2096
The ALTER TABLE parser did not account for all value types when setting a column's default value.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derickl perfect, thanks for adding this! 🥇

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #2101 (7408730) into main (f99d9b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2101   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10608     10608           
=========================================
  Hits         10608     10608           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99d9b3...7408730. Read the comment docs.

@jpy-git jpy-git changed the title Allow for more value types in ATER TABLE ALTER COLUMN DEFAULT statement Allow for more value types in ALTER TABLE ALTER COLUMN SET DEFAULT statement Dec 12, 2021
@jpy-git jpy-git merged commit 78a92a9 into sqlfluff:main Dec 12, 2021
@derickl derickl deleted the fixup-alter-table-postgres branch December 12, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants