Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin markupsafe to prevent CI failures #2685

Merged
merged 4 commits into from Feb 18, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #2684

Are there any other side effects of this change that we should be aware of?

Should unpin when dependencies update

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #2685 (c059835) into main (f600224) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2685   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        12023     12023           
=========================================
  Hits         12023     12023           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f600224...c059835. Read the comment docs.

@barrywhart
Copy link
Member

I'm unclear: what code is using markup_safe and soft_unicode? I searched our code and didn't find any usage, so I assume it's a second-level dependency?

@tunetheweb
Copy link
Member Author

A little package called Jinja2. And the fact DBT is using a really old version of it!

Any chatter on dbt slack on this?

@tunetheweb
Copy link
Member Author

dbt-labs/dbt-core#4746

@barrywhart
Copy link
Member

I don't see anything on Slack, but I'm only in a few channels. I'll try a search.

@tunetheweb tunetheweb merged commit d6a918a into sqlfluff:main Feb 18, 2022
@tunetheweb tunetheweb deleted the pin-markupsafewq branch February 18, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markupsafe 2.1.0 has deprecated soft_unicode but still required.
3 participants