Pin MarkupSafe==2.0.1
#4746
Merged
Pin MarkupSafe==2.0.1
#4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
approved these changes
Feb 18, 2022
jtcohen6
added
the
backport 1.0.latest
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-4746-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 a66fe7f4674eb5dcb1dcfb34652c4975da9eaa5a
# Push it to GitHub
git push --set-upstream origin backport-4746-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latestThen, create a pull request where the |
jtcohen6
added a commit
that referenced
this pull request
Feb 18, 2022
This was referenced Feb 18, 2022
leahwicz
pushed a commit
that referenced
this pull request
Feb 18, 2022
1 task
timle2
pushed a commit
to timle2/dbt-core
that referenced
this pull request
Feb 21, 2022
adamantike
added a commit
to adamantike/dbt-core
that referenced
this pull request
Apr 12, 2022
The current `MarkupSafe` pinned version has been added in dbt-labs#4746 as a temporary fix for dbt-labs#4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
4 tasks
ChenyuLInx
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
VersusFacit
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
leahwicz
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
leahwicz
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
leahwicz
added a commit
that referenced
this pull request
Apr 19, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53 Co-authored-by: Michael Manganiello <adamantike@users.noreply.github.com>
leahwicz
added a commit
that referenced
this pull request
May 9, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in #4746 as a temporary fix for #4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53 Co-authored-by: Michael Manganiello <adamantike@users.noreply.github.com>
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
* Flexibilize MarkupSafe pinned version The current `MarkupSafe` pinned version has been added in dbt-labs#4746 as a temporary fix for dbt-labs#4745. However, the current restrictive approach isn't compatible with other libraries that could require an even older version of `MarkupSafe`, like Airflow `2.2.2` [0], which requires `markupsafe>=1.1.1, <2.0`. To avoid that issue, we can allow a greater range of supported `MarkupSafe` versions. Considering the direct dependency `dbt-core` has is `Jinja2==2.11.3`, we can use its pinning as the lower bound, which is `MarkupSafe>=0.23` [1]. This fix should be also backported this to `1.0.latest` for inclusion in the next v1.0 patch. [0] https://github.com/adamantike/airflow/blob/2.2.2/setup.cfg#L125 [1] https://github.com/pallets/jinja/blob/2.11.3/setup.py#L53
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4745
main1.0.latestfor inclusion in the next v1.0 patch (v1.0.2)