Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Move some keywords to unreserved #3002

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

As part of #2989 two new keywords were added to BigQuery as Reserved Words, but they should have been added as Unreserved words and they are now causing some of my queries to fail.

FYI @dmohns

Are there any other side effects of this change that we should be aware of?

Nope

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #3002 (e71cf52) into main (e064697) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3002   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines        11994     11994           
=========================================
  Hits         11994     11994           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_bigquery_keywords.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e064697...e71cf52. Read the comment docs.

@dmohns
Copy link
Contributor

dmohns commented Apr 5, 2022

Thanks for the fix! I was actually just running into the same issue.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit 9818555 into sqlfluff:main Apr 5, 2022
@tunetheweb tunetheweb deleted the bigquery-keyword-fixes branch April 5, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants