Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L025: Derived query requires alias -- also handle UNION, etc. #3548

Conversation

barrywhart
Copy link
Member

@barrywhart barrywhart commented Jul 3, 2022

Brief summary of the change made

Fixes #3547
This is a one-line change to yesterday's PR (#3546)

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #3548 (3fc82ec) into main (fe8b93e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines        13064     13064           
=========================================
  Hits         13064     13064           
Impacted Files Coverage Δ
src/sqlfluff/rules/L025.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8b93e...3fc82ec. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Could you do me a favour though and search the rules for set_expression? I’ve a funny feeling another rules uses that with select_expression and one other too which we might want to add here.

@barrywhart
Copy link
Member Author

Will do. It'll probably be this afternoon. I'm about to go somewhere with the family.

@tunetheweb
Copy link
Member

Maybe just merge this in meantime then?

@barrywhart
Copy link
Member Author

@tunetheweb: Good catch! The other case is with_compound_statement. I added a test case and a fix for that too. Once the build passes, I'll merge this and make the release.

@barrywhart barrywhart merged commit b66071c into sqlfluff:main Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsql: code corruption alias removed L025
2 participants