Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L025: Derived query requires alias -- also handle UNION, etc. #3548

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sqlfluff/rules/L025.py
Expand Up @@ -121,7 +121,9 @@ def is_alias_required(
dialect_name in cls._dialects_requiring_alias_for_values_clause
)
elif any(
seg.is_type("select_statement")
seg.is_type(
"select_statement", "set_expression", "with_compound_statement"
)
for seg in segment.iter_segments(expanding=("bracketed",))
):
# The FROM expression is a derived table, i.e. a nested
Expand Down
22 changes: 21 additions & 1 deletion test/fixtures/rules/std_rule_cases/L025.yml
Expand Up @@ -312,8 +312,28 @@ test_fail_snowflake_flatten_function:
core:
dialect: snowflake

test_pass_derived_query_requires_alias:
test_pass_derived_query_requires_alias_1:
# Case 1: Simple derived query
pass_str: |
SELECT * FROM (
SELECT 1
) as a

test_pass_derived_query_requires_alias_2:
# Case 2: Derived query uses set operation (UNION)
pass_str: |
SELECT * FROM (
SELECT col FROM dbo.tab
UNION
SELECT -1 AS col
) AS a

test_pass_derived_query_requires_alias_3:
# Case 3: Derived query includes a WITH statement
pass_str: |
SELECT * FROM (
WITH foo AS (
SELECT col FROM dbo.tab
)
SELECT * FROM foo
) AS a