Update CI to use Python 3.11 #4038
Conversation
| result["selectables"] = [ | ||
| s.as_str() for s in self.selectables | ||
| ] # type: ignore | ||
| result["selectables"] = [s.as_str() for s in self.selectables] |
There was a problem hiding this comment.
3.11 thinks that this ignore is not needed, but someone with an old Python locally would get the opposite error when they try to commit.
We could keep the mypy check on 3.10, or also just wait 6 months to do this PR.
There was a problem hiding this comment.
what's the error? There might be another way around the type hinting here to make both of them happy.
There was a problem hiding this comment.
actually - I'm running an older version so I can check myself! Have just pushed a fix which should work for both.
Codecov ReportBase: 99.93% // Head: 99.93% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4038 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 190 190
Lines 14536 14536
=======================================
Hits 14527 14527
Misses 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Great idea @greg-finley - the potential speed improvements in 3.11 would be a good addition to the test suite. |
Was just curious if it works yet. If so, why not?