Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upload 3 sets of test results to codecov (possible workaround for hanging builds) #4147

Conversation

barrywhart
Copy link
Member

@barrywhart barrywhart commented Dec 9, 2022

Brief summary of the change made

Fixes #4146

Only require (and upload) coverage reports for:

  • Python 3.11
  • dbt 1.3.0
  • Python Windows

Allegedly, uploading fewer coverage reports makes the coverage portion of the CI build less likely to hang.

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@greg-finley greg-finley linked an issue Dec 9, 2022 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (af18908) compared to base (71d6cdb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        14922     14920    -2     
=========================================
- Hits         14922     14920    -2     
Impacted Files Coverage Δ
src/sqlfluff/__init__.py 100.00% <ø> (ø)
src/sqlfluff/core/cached_property.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@greg-finley
Copy link
Contributor

Mind fixing the few coverage gaps it has now?

@@ -41,7 +41,25 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ '3.7', '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '3.7', '3.8', '3.9', '3.10' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to put some comment that old versions don't have coverage. So hopefully the next person, when 3.12 comes out, will know to put 3.11 in this list and put 3.12 on line 62.

@@ -120,7 +138,42 @@ jobs:
- 5432:5432
strategy:
matrix:
dbt-version: [ 'dbt020', 'dbt021', 'dbt100', 'dbt130' ]
dbt-version: [ 'dbt020', 'dbt021', 'dbt100' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto about comment to help us when bumping this version in the future

@greg-finley
Copy link
Contributor

greg-finley commented Dec 9, 2022

There might be a syntax like if ... a certain matrix value, then run coverage. Like how this page mentions - if: ${{ matrix.npm }}. Would be great if we can keep the original matrix and just run the coverage step conditionally vs having to copy all the steps.

@barrywhart
Copy link
Member Author

The if syntax doesn't seem well documented to me. Let's save that for a future PR.

@barrywhart
Copy link
Member Author

@greg-finley: Ready for another review. Addressed everything except adding if. I'm afraid trying to do that could open a can of worms -- this is all the time I can spare to work on this today.

Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great!

@greg-finley greg-finley merged commit 42db36b into sqlfluff:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce number of reports sent to codecov
2 participants