New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only upload 3 sets of test results to codecov (possible workaround for hanging builds) #4147
Merged
greg-finley
merged 2 commits into
sqlfluff:main
from
barrywhart:bhart-issue_4146_reduce_coverage_reports_sent_to_codecov
Dec 9, 2022
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,25 @@ jobs: | |
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [ '3.7', '3.8', '3.9', '3.10', '3.11' ] | ||
python-version: [ '3.7', '3.8', '3.9', '3.10' ] | ||
name: Python ${{ matrix.python-version }} tests | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install dependencies | ||
run: | | ||
pip install tox | ||
- name: Run the tests | ||
run: | | ||
tox -e py -- -n 2 test | ||
python-version-tests-cov: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [ '3.11' ] | ||
name: Python ${{ matrix.python-version }} tests | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
@@ -120,7 +138,42 @@ jobs: | |
- 5432:5432 | ||
strategy: | ||
matrix: | ||
dbt-version: [ 'dbt020', 'dbt021', 'dbt100', 'dbt130' ] | ||
dbt-version: [ 'dbt020', 'dbt021', 'dbt100' ] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto about comment to help us when bumping this version in the future |
||
name: DBT Plugin ${{ matrix.dbt-version }} tests | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: '3.8' | ||
- name: Install dependencies | ||
run: | | ||
pip install tox | ||
- name: Run the tests | ||
run: | | ||
tox -e ${{ matrix.dbt-version }} -- plugins/sqlfluff-templater-dbt | ||
dbt-tests-cov: | ||
runs-on: ubuntu-latest | ||
services: | ||
# Label used to access the service container | ||
postgres: | ||
# Docker Hub image | ||
image: postgres | ||
# Provide the password for postgres | ||
env: | ||
POSTGRES_PASSWORD: password | ||
# Set health checks to wait until postgres has started | ||
options: >- | ||
--health-cmd pg_isready | ||
--health-interval 10s | ||
--health-timeout 5s | ||
--health-retries 5 | ||
ports: | ||
# Maps tcp port 5432 on service container to the host | ||
- 5432:5432 | ||
strategy: | ||
matrix: | ||
dbt-version: [ 'dbt130' ] | ||
name: DBT Plugin ${{ matrix.dbt-version }} tests | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
@@ -202,10 +255,6 @@ jobs: | |
# None of these test need temp dir set | ||
run: | | ||
python -m tox -e dbt100-winpy -- plugins/sqlfluff-templater-dbt | ||
- name: Upload Coverage Report | ||
uses: codecov/codecov-action@v1 | ||
with: | ||
files: ./coverage.xml | ||
pip-test-pull-request: | ||
# Test that using pip install works as we've missed | ||
# some dependencies in the past - see #1842 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to put some comment that old versions don't have coverage. So hopefully the next person, when 3.12 comes out, will know to put 3.11 in this list and put 3.12 on line 62.