Layout Rules Recode (part 2) #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmcruickshank
force-pushed
the
ac/rules_reorg_more_spacing
branch
from
02d3c26
to
01401db
Compare
src/sqlfluff/utils/reflow/respace.py
Outdated
| post_constraint = next_block.spacing_before if next_block else "single" | ||
| # Unless align, split. | ||
| if post_constraint.startswith("align"): |
There was a problem hiding this comment.
Can you not just loop through the constraints rather than repeating the code block?
There was a problem hiding this comment.
yeah that's probably a better idea... 🤔
Pull Request Test Coverage Report for Build 4331471805
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4336164845
💛 - Coveralls |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4456 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 211 204 -7
Lines 15498 15415 -83
=========================================
- Hits 15498 15415 -83
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alanmcruickshank
changed the title
Merged
pwildenhain
reviewed
Mar 5, 2023
| @@ -291,7 +291,7 @@ above: | |||
| .. code-block:: cfg | |||
|
|
|||
| [sqlfluff] | |||
| warnings = L019, L006 | |||
| warnings = L019, LT01 | |||
There was a problem hiding this comment.
Oh interesting, I didn't know we were downgrading this to a warning
There was a problem hiding this comment.
... we're not - it's just an example 😄
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on from #4432 . It's part of #4031 .
This PR is primarily about consolidating all the other spacing rules into
LT01. This removes a lot of individual rules, but results in much less code to basically do the same thing. We rely on layout configs to allow users to tweek formats for their setup. Specifically,LT01now combines:In the process this also revises a couple of spacing configurations. In particular I've changed
inlineto be a qualifier so that we can havesingle:inlineandtouch:inline(where the latter was the previous meaning of justinline). This also allows a little more modularity in the code which handles it.In the original issue - I suggested that we should also combine L015 and L017 into here too, but on closer inspection I think that's a bad idea. I'll handle them separately.