Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules Reorg Mopup #4462

Merged
merged 13 commits into from Mar 5, 2023
Merged

Rules Reorg Mopup #4462

merged 13 commits into from Mar 5, 2023

Conversation

alanmcruickshank
Copy link
Member

@alanmcruickshank alanmcruickshank commented Mar 5, 2023

Almost done with #4031. This picks up a selection of rules that haven't been recoded yet and puts them into existing bundles. No significant functionality changes.

  • L009 -> LT12
  • L015 -> ST08 (this one was originally slated to be a layout rule, but I think it's actually structural)
  • L016 -> LT05
  • L017 -> LT06
  • L018 -> LT07
  • L022 -> LT08
  • L036 -> LT09
  • L041 -> LT10
  • L065 -> LT11

After this PR (and #4456), we're almost done with recode. It leaves only L031 and L050 to go - which are slightly more complicated cases.

@coveralls
Copy link

coveralls commented Mar 5, 2023

Pull Request Test Coverage Report for Build 4337134503

  • 68 of 68 (100.0%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4336997133: 0.0%
Covered Lines: 17274
Relevant Lines: 17274

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (ce57b75) 100.00% compared to head (4b36484) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4462   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          204       204           
  Lines        15415     15444   +29     
=========================================
+ Hits         15415     15444   +29     
Impacted Files Coverage Δ
...-templater-dbt/sqlfluff_templater_dbt/templater.py 100.00% <ø> (ø)
src/sqlfluff/cli/commands.py 100.00% <ø> (ø)
src/sqlfluff/core/config.py 100.00% <ø> (ø)
src/sqlfluff/core/linter/linter.py 100.00% <ø> (ø)
src/sqlfluff/core/rules/base.py 100.00% <ø> (ø)
src/sqlfluff/rules/layout/LT03.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/layout/LT04.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/layout/LT05.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/layout/LT06.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/layout/LT07.py 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alanmcruickshank alanmcruickshank marked this pull request as ready for review March 5, 2023 16:36
@alanmcruickshank alanmcruickshank changed the title [draft] Rules Reorg Mopup Rules Reorg Mopup Mar 5, 2023
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files changed 104 💀 but LGTM

@alanmcruickshank alanmcruickshank merged commit eea8e46 into main Mar 5, 2023
@alanmcruickshank alanmcruickshank deleted the ac/rules_reorg_mopup branch March 5, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants