Skip to content
Browse files
Get the encoding name from a combo box in the "Set encoding" dialog
User can enter the encoding name with completion or select it from the
list using the mouse. This will help users to discover available codecs
and to find a suitable one in an easier way. This should help with encoding
issues like #1453.
  • Loading branch information
mgrojo committed Jun 29, 2018
1 parent 98f4b88 commit 588363b7f6fe70a32986e5d48781980eb6876d5b
Showing with 19 additions and 3 deletions.
  1. +8 −0 src/Data.cpp
  2. +2 −0 src/Data.h
  3. +9 −3 src/MainWindow.cpp
@@ -57,3 +57,11 @@ QByteArray removeBom(QByteArray& data)
return QByteArray();

QStringList toStringList(const QList<QByteArray> list) {
QStringList strings;
for (const QByteArray &item : list) {
return strings;
@@ -17,4 +17,6 @@ bool startsWithBom(const QByteArray& data);
// with a BOM an empty byte array is returned and the original data is not modified.
QByteArray removeBom(QByteArray& data);

QStringList toStringList(const QList<QByteArray> list);

@@ -25,6 +25,7 @@
#include "RemoteDock.h"
#include "RemoteDatabase.h"
#include "FindReplaceDialog.h"
#include "Data.h"

#include <QFile>
#include <QApplication>
@@ -2773,15 +2774,20 @@ void MainWindow::browseDataSetTableEncoding(bool forAllTables)
// Ask the user for a new encoding
bool ok;
QString question;
QStringList availableCodecs = toStringList(QTextCodec::availableCodecs());
int currentItem = availableCodecs.indexOf(encoding);

question = tr("Please choose a new encoding for all tables.");
question = tr("Please choose a new encoding for this table.");
encoding = QInputDialog::getText(this,
encoding = QInputDialog::getItem(this,
tr("Set encoding"),
tr("%1\nLeave the field empty for using the database encoding.").arg(question),
true, // editable

// Only set the new encoding if the user clicked the OK button

0 comments on commit 588363b

Please sign in to comment.