Skip to content

Commit

Permalink
Better BLOB detection in the Browse Data tab
Browse files Browse the repository at this point in the history
This improves the BLOB detection in the Browse Data tab which was
working pretty poorly because it was only looking for null bytes, not
for any other non-printable characters.

See issue #1201.
  • Loading branch information
MKleusberg committed Oct 29, 2017
1 parent 557ef39 commit 9b30940
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/sqlitetablemodel.cpp
Expand Up @@ -839,7 +839,10 @@ void SqliteTableModel::clearCache()

bool SqliteTableModel::isBinary(const QModelIndex& index) const
{
return m_data.at(index.row()).at(index.column()).left(1024).contains('\0');
// We're using the same way to detect binary data here as in the EditDialog class. For performance reasons we're only looking at
// the first couple of bytes though.
QByteArray data = m_data.at(index.row()).at(index.column()).left(512);
return QString(data).toUtf8() != data;
}

QByteArray SqliteTableModel::encode(const QByteArray& str) const
Expand Down

0 comments on commit 9b30940

Please sign in to comment.